Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(e2e): run e2e tests in parallel #54

Merged
merged 5 commits into from
Sep 18, 2024
Merged

chore(e2e): run e2e tests in parallel #54

merged 5 commits into from
Sep 18, 2024

Conversation

Lazar955
Copy link
Member

@Lazar955 Lazar955 commented Sep 18, 2024

Execute e2e tests in parallel.
Speed up from 15m -> 3m

Makefile Outdated
@@ -48,7 +48,7 @@ test:
go test -race ./...

test-e2e:
go test -race -mod=readonly --failfast -timeout=25m -v $(PACKAGES_E2E) -count=1 --tags=e2e
go test -mod=readonly --failfast -timeout=25m -v $(PACKAGES_E2E) -count=1 --parallel 10 --tags=e2e
Copy link
Member Author

@Lazar955 Lazar955 Sep 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed the -race flag, as there were quite a bit of race conditions not related to the testing code, but some in Babylon some in cosmos SDK. Will open an issue to investigate this

-parallel N -> limits the number of concurrent tests to N, we can play around with this, will depend on how much we can stress GH actions, or remove the limit

Copy link
Member

@gitferry gitferry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great!

Copy link
Contributor

@RafilxTenfen RafilxTenfen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 Awesome!

"9090",
"26656",
"26657",
"9090/tcp", // only expose what we need
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@Lazar955 Lazar955 merged commit 8908a8d into main Sep 18, 2024
8 checks passed
@Lazar955 Lazar955 deleted the lazar/e2e-parallel branch September 18, 2024 11:54
@Lazar955 Lazar955 mentioned this pull request Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants